Add CAD-based sample points#132
Open
wegank wants to merge 1 commit intoalgebraic-solving:mainfrom
Open
Conversation
wegank
force-pushed
the
sample-points-init
branch
2 times, most recently
from
416ef4a to
557d972
Compare
wegank
force-pushed
the
sample-points-init
branch
2 times, most recently
from
c2e9195 to
93f2fb5
Compare
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #132 +/- ##
==========================================
+ Coverage 83.56% 83.65% +0.09%
==========================================
Files 31 33 +2
Lines 3084 3310 +226
==========================================
+ Hits 2577 2769 +192
- Misses 507 541 +34 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wegank
force-pushed
the
sample-points-init
branch
2 times, most recently
from
075d46d to
150856c
Compare
wegank
force-pushed
the
sample-points-init
branch
2 times, most recently
from
3a66105 to
ad10edd
Compare
wegank
force-pushed
the
sample-points-init
branch
from
ad10edd to
93e6814
Compare
wegank
force-pushed
the
sample-points-init
branch
from
93e6814 to
5381280
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
points_per_componentswhich computes at least one point per connected component of a semi-algebraic set defined by equations, positivity constraints and non-vanishing constraints. The signature is almost identical to that ofPointsPerComponentsfrom RAGlib.Depends on #131.